[PATCH] D31847: [PowerPC] Eliminate compares in instruction selection - Vol. 1

[Nemanja Ivanovic via Phabricator via llvm-commits]

nemanjai added inline comments.


================
Comment at: lib/Target/PowerPC/PPCISelDAGToDAG.cpp:2684
+    cast<CondCodeSDNode>(Compare.getOperand(IsSelectCC ? 4 : 2))->get();
+  EVT InputVT = LHS.getValueType();
+  if (InputVT != MVT::i32 && InputVT != MVT::i64)
----------------
nemanjai wrote:
> echristo wrote:
> > MVT InputVT
> I thought we typically used the EVT class for this type of thing but sure.
On second thought, looks like it'll have to stay an EVT or else I'd have to call `getSimpleType()` on the result of `getValueType()`.


Repository:
  rL LLVM

https://reviews.llvm.org/D31847