[PATCH] D33018: [compiler-rt][cmake] Provide empty version of enable_execute_stack for baremetal targets
Joerg Sonnenberger via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue May 9 17:03:31 PDT 2017
joerg added a comment.
To expand on what I said on IRC:
(1) I don't think anything should normally call it. For GCC, it depends on the target configuration whether it believes __enable_execute_stack is supported/required or not.
(2) We shouldn't fail to build compiler-rt for this.
(3) It is better to fail linking a user program with this when it is not expected / wasted code than silently hiding the problem.
As such, I'd prefer to just skip the whole default implementation for platforms where it shouldn't be used. This includes bare-metal.
https://reviews.llvm.org/D33018
More information about the llvm-commits
mailing list