[PATCH] D31788: [ConstantFolding] Add folding for various math '__<func>_finite' routines generated from -ffast-math

[Andy Kaylor via Phabricator via llvm-commits]

andrew.w.kaylor added inline comments.


================
Comment at: test/Transforms/ConstProp/calls-math-finite.ll:35
+
+; CHECK-NOT: call
+; CHECK: ret
----------------
chrischr wrote:
> andrew.w.kaylor wrote:
> > chrischr wrote:
> > > andrew.w.kaylor wrote:
> > > > Won't this test fail on targets where these functions were marked as unavailable?
> > > Currently the test case is written without specifying a target triple, so the default OS value (UnknownOS) is in effect during the initialization of the TLI preventing the  TLI.setUnavailable calls from executing. 
> > > 
> > I thought these tests would pick up the triple from the host if nothing was specified.  Have you run this test on Windows?
> I single stepped 'opt.exe' within Visual Studio, and saw it set to UnknownOS when looking at the local vars. 
> 
> Also, test passes for me when running llvm-lit.py on Wndows.
> 
> 
OK.  Thanks.


https://reviews.llvm.org/D31788