[PATCH] D33018: [compiler-rt][cmake] Provide empty version of enable_execute_stack for baremetal targets

[Jonathan Roelofs via Phabricator via llvm-commits]

jroelofs requested changes to this revision.
jroelofs added inline comments.
This revision now requires changes to proceed.


================
Comment at: lib/builtins/CMakeLists.txt:193
 
+if(COMPILER_RT_BAREMETAL_BUILD)
+  set(GENERIC_SOURCES
----------------
This blob of cmake goop would be simplified if, rather than having two files for `enable_execute_stack{_empty,}.c`, the flag just controlled the body's existence in `enable_execute_stack.c`.


================
Comment at: lib/builtins/enable_execute_stack_empty.c:6
+void
+__enable_execute_stack (void *addr __attribute__((__unused__)))
+{
----------------
LLVM style nit: we don't put a space between function names and the opening paren.


https://reviews.llvm.org/D33018