[PATCH] D32887: [ELF] Emit __ehdr_start when there is a segment containing program headers

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 9 13:08:45 PDT 2017


ruiu added a comment.

These possible compatibility issues could be real concerns, but I think we should go with a simple way which is to define ehdr_start unconditionally. When we need to strike a balance among simplicity, efficiency and compatibility, we sometimes chose simplicity or efficiency over the 100% precise compatibility, and it seems to be working surprisingly well. It feels __ehdr_start is in the same category. We can add more code later if it really needs more complexity.


Repository:
  rL LLVM

https://reviews.llvm.org/D32887





More information about the llvm-commits mailing list