[PATCH] D33014: Fix the Endianness bug by adding the little endian UTF marker.

Zachary Turner via llvm-commits llvm-commits at lists.llvm.org
Tue May 9 12:34:39 PDT 2017


Yes, bot is red. Even still, the unicode api fix is rather involved (I
actually tried) and it doesn't seem worth blocking this on that since it's
largely unrelated and there are a lot of boring details to handle like
which subset of apis to do it for, how to restructure the multiple
overloads to share code, etc
On Tue, May 9, 2017 at 12:32 PM Rui Ueyama via Phabricator <
reviews at reviews.llvm.org> wrote:

> ruiu added a comment.
>
> Do you mean the bot is still red? If I broke something I'd first try to
> roll it back if the error is not just a simple mistake but needs another
> round of code review.
>
>
> https://reviews.llvm.org/D33014
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170509/b153eaf1/attachment.html>


More information about the llvm-commits mailing list