[PATCH] D30471: [SDAG] Relax conditions under stores of loaded values can be merged

[Eli Friedman via Phabricator via llvm-commits]

efriedma added inline comments.


================
Comment at: lib/CodeGen/SelectionDAG/DAGCombiner.cpp:12941
+      // the TokenFactor.
+      SDValue TokenDummy = DAG.getNode(ISD::TokenFactor, SDLoc(Ld), MVT::Other);
+
----------------
The approach makes sense... but I'm surprised a TokenFactor with zero operands doesn't cause an assertion failure somewhere.  Could you use a new opcode for this?

Also, please add an assertion that TokenDummy has zero uses.


https://reviews.llvm.org/D30471