[PATCH] D31787: [TLI] Add declarations for various math header file routines from math-finite.h that create '__<func>_finite as functions

Chris Chrulski via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 9 10:41:28 PDT 2017


chrischr added inline comments.


================
Comment at: lib/Analysis/TargetLibraryInfo.cpp:243
+
+      // These definitions are due to math-finite.h header on Linux
+      TLI.setUnavailable(LibFunc_acos_finite);
----------------
andrew.w.kaylor wrote:
> Am I reading this correctly as saying these will only be marked as unavailable for 32-bit Windows targets?  The comment implies they should be unavailable for all Windows targets, right?
Good point, you are correct. These should be moved outside of this 'if' condition. I'll fix and upload a new revision.




https://reviews.llvm.org/D31787





More information about the llvm-commits mailing list