[PATCH] D32541: Supress all uses of LLVM_END_WITH_NULL

[Mehdi AMINI via Phabricator via llvm-commits]

mehdi_amini accepted this revision.
mehdi_amini added a comment.
This revision is now accepted and ready to land.

LGTM (provided you build/tested clang)



================
Comment at: lib/Transforms/Instrumentation/DataFlowSanitizer.cpp:479
         PointerType::getUnqual(
-            FunctionType::get(PointerType::getUnqual(ArgTLSTy),
-                              (Type *)nullptr)));
+            FunctionType::get(PointerType::getUnqual(ArgTLSTy), false)));
   }
----------------
serge-sans-paille wrote:
> mehdi_amini wrote:
> > Why do you need the false here?
> That's not related to this commit. the function signature is : ``static FunctionType * 	get (const Type *Result, bool isVarArg)`` so passing a casted null pointer was indeed working, but that's not very explicit :-/
> That's not related to this commit.

So commit it separately?
(you don't need a review for that)


Repository:
  rL LLVM

https://reviews.llvm.org/D32541