[PATCH] D32965: [GlobalISel][X86] G_ZEXT i1 to i32/i64 support.

[Guy Blank via Phabricator via llvm-commits]

guyblank added inline comments.


================
Comment at: lib/Target/X86/X86LegalizerInfo.cpp:90
 
-  for (auto Ty : {s8, s16}) {
+  for (auto Ty : {s1, s8, s16}) {
     setAction({G_ZEXT, 1, Ty}, Legal);
----------------
igorb wrote:
> guyblank wrote:
> > is the SEXT legalization intentional? 
> Yes, i think to mark G_SEXT i1 as legal operation and lower it to AND + NEG sequence  in InstructionSelector. 
> G_SEXT Instruction selection not implemented in this patch.
> relevant legalize testes for G_SEXT added. 
ok, but you're missing the legalize test for s1->s64 sext


https://reviews.llvm.org/D32965