[PATCH] D32965: [GlobalISel][X86] G_ZEXT i1 to i32/i64 support.

[Guy Blank via Phabricator via llvm-commits]

guyblank added a comment.

In https://reviews.llvm.org/D32965#749418, @igorb wrote:

> In https://reviews.llvm.org/D32965#749403, @guyblank wrote:
>
> > General question, why do we need to support selection on i1? can't we widen it?
>
>
> Widening done using  G_ZEXT ( in some cases G_ANYEXT) so i need to support  G_ZEXT selection in any case.


ok

In https://reviews.llvm.org/D32965#749418, @igorb wrote:

> In https://reviews.llvm.org/D32965#749403, @guyblank wrote:
>
> > General question, why do we need to support selection on i1? can't we widen it?
>
>
> Widening done using  G_ZEXT ( in some cases G_ANYEXT) so i need to support  G_ZEXT selection in any case.


i assume that the reason why use have custom code for lowering is that the tablegen patterns aren't fully supported. but once they will be supported, we'll need to have various patterns for illegal types as well? for G_ZEXT or any other instructions the legalize pass creates.


https://reviews.llvm.org/D32965