[PATCH] D32614: [GVNHoist] Fix: PR32821, add check for anticipability in case of infinite loops

[Chandler Carruth via Phabricator via llvm-commits]

chandlerc added a comment.

You are continuing to argue that you do not need to add tests because they will pass. That seems to be missing the point. Tests are what verify and validate these kinds of arguments and assumptions, both now and in the future.

I already said in my response that I acknowledge that these tests will likely pass. It still seems extremely important to have specific, targeted test coverage of the different kinds of control flows. I will stop repeating myself after this message.


https://reviews.llvm.org/D32614