[PATCH] D32980: Use the frame index side table for byval and inalloca arguments

[Adrian Prantl via Phabricator via llvm-commits]

aprantl accepted this revision.
aprantl added a comment.
This revision is now accepted and ready to land.

This looks generally good (with outstanding comments addressed), thanks!

Is there a testcase for the example that you mention in the description?

Please keep a close eye on the green dragon bots, both the ones in the debuginfo-tests repository that execute as part of each check-clang, as well as the lldb testsuite, after landing this.



================
Comment at: llvm/lib/CodeGen/SelectionDAG/SelectionDAGISel.cpp:1183
+      // dbg.value.
+      if (const auto *Arg = dyn_cast<Argument>(Address))
+        FI = FuncInfo->getArgumentFrameIndex(Arg);
----------------
else if ?


================
Comment at: llvm/test/CodeGen/X86/dbg-baseptr.ll:62
+; DWARF:   DW_TAG_formal_parameter
+; DWARF-NEXT:     DW_AT_location [DW_FORM_exprloc]      (<0x2> 91 10 )
+; DWARF-NEXT:     DW_AT_name [DW_FORM_strp]     ( {{.*}}"input")
----------------
please add the disassembly as a comment: (such as DW_OP_fbreg +16 )


================
Comment at: llvm/test/DebugInfo/X86/dbg-declare-inalloca.ll:105
+
+attributes #0 = { nounwind "correctly-rounded-divide-sqrt-fp-math"="false" "disable-tail-calls"="false" "less-precise-fpmad"="false" "no-frame-pointer-elim"="false" "no-infs-fp-math"="false" "no-jump-tables"="false" "no-nans-fp-math"="false" "no-signed-zeros-fp-math"="false" "no-trapping-math"="false" "stack-protector-buffer-size"="8" "target-cpu"="pentium4" "target-features"="+fxsr,+mmx,+sse,+sse2,+x87" "unsafe-fp-math"="false" "use-soft-float"="false" }
+attributes #1 = { nounwind readnone speculatable }
----------------
We typically delete all unnecessary attributes from testcases.


https://reviews.llvm.org/D32980