[PATCH] D32277: Replace slow LEA instructions in X86

Lama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon May 8 06:10:38 PDT 2017


lsaba marked 2 inline comments as done.
lsaba added inline comments.


================
Comment at: lib/Target/X86/X86FixupLEAs.cpp:312
+  int Opcode = MI.getOpcode();
+  const MachineOperand &Offset = MI.getOperand(4);
+  switch (Opcode) {
----------------
zvi wrote:
> Sorry for not pointing this out earlier, but here is another index-magic case we can avoid by passing Offset to this function, this function can possibly be changed to
> 
> ```
> getADDFromLEA(int LEAOpcode, const MachineOperand &Offset, bool IsImm)
> ```
Decided to split this into 2 functions as well


https://reviews.llvm.org/D32277





More information about the llvm-commits mailing list