[PATCH] D32498: [CodeView] omit forward references for unnamed structs and unions

Brock Wyma via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon May 8 05:38:53 PDT 2017


bwyma added a comment.

Unnamed C++ structs are given a name as of https://reviews.llvm.org/rL274401, so unnamed structs containing a method will have a name assigned to them and will not create a cycle in this case.

If you feel strongly about naming these then I can improvise a name as you suggested, but I believe the current proposal has two minor advantages:

1. Visual Studio omits the forward reference for these types and compatibility is generally a good thing.
2. Omitting the forward reference and eliminating the manufactured name will use less space, and keeping the debug information size small whenever possible is desirable.

If you are willing to accept this suggestion but are still concerned about potential cycles in the type graph, then I can add additional code to prevent them.

Let me know what you think.


https://reviews.llvm.org/D32498





More information about the llvm-commits mailing list