[PATCH] D30086: Add generic IR vector reductions

[Renato Golin via Phabricator via llvm-commits]

rengolin added a comment.

Hi Amara,

Thanks for the update, this is what I had in mind, yes.

I just have one additional small comment inline, and one small (probably irrelevant) nitpick.

cheers,
--renato



================
Comment at: lib/Transforms/Utils/LoopUtils.cpp:1273
+    return getSimpleRdx(Instruction::Xor);
+  case RecurrenceDescriptor::RK_IntegerMinMax: {
+    switch (Desc.getMinMaxRecurrenceKind()) {
----------------
I may be wrong, but I think the LLVM style could be to put this curly brackets on a new line.

clang-format would know better. :)


================
Comment at: lib/Transforms/Utils/LoopUtils.cpp:1293
+  case RecurrenceDescriptor::RK_FloatMinMax: {
+    Flags.IsMaxOp =
+        Desc.getMinMaxRecurrenceKind() == RecurrenceDescriptor::MRK_FloatMax;
----------------
Isn't this `Flags` a local variable? Where is this being used after the call to `createSimpleTargetReduction`?


Repository:
  rL LLVM

https://reviews.llvm.org/D30086