[PATCH] D32059: Make AssumptionCache's interface return a range of Values

[Hal Finkel via Phabricator via llvm-commits]

hfinkel added inline comments.


================
Comment at: include/llvm/Analysis/AssumptionCache.h:116
+  struct NullVHFilter {
+    bool operator()(const WeakVH& wvh) const {
+      return wvh;
----------------
Our general convention for variables is that they start with a capital letter (for acronyms, this sometimes means we have variable names in all caps, but that's okay).  So:
  wvh -> WVH


================
Comment at: lib/Transforms/InstCombine/InstCombineSelect.cpp:1479
+  auto assumptions = AC.assumptions();
+  if (!CondVal->getType()->isVectorTy() && assumptions.begin() != assumptions.end()) {
     KnownBits Known(1);
----------------
This line is more than 80 characters; please wrap.


https://reviews.llvm.org/D32059