[PATCH] D21723: [RFC] Enhance synchscope representation

[Tony Tye via Phabricator via llvm-commits]

t-tye added inline comments.


================
Comment at: lib/Bitcode/Reader/BitcodeReader.cpp:1784
+  }
+}
+
----------------
If the sync scope block is present, should be required to have at least one entry? That would be consistent with the assert for checking for duplicate blocks above (since it relies on SSIDs not being empty), and the writer seems to ensure that it never generates empty blocks. (In practice there will always be 2 entries for the singlethread and empty system scopes, but that could change in the future.)

```
if (SSIDs.empty())
  return error("Invalid empty sync scope names block");
```




https://reviews.llvm.org/D21723