[PATCH] D32946: [InstCombine] Merge duplicate functionality between InstCombine and ValueTracking

[Craig Topper via Phabricator via llvm-commits]

craig.topper added inline comments.


================
Comment at: lib/Analysis/ValueTracking.cpp:3523
+    MaxRHS.clearSignBit();
+    APInt Result = std::move(MaxLHS) + std::move(MaxRHS);
+    return Result.isSignBitClear();
----------------
takuto.ikuta wrote:
> Can I ask you to remove `std::move`s?
> These have no meaning here.
They do have meaning. APInt's operator+ is setup to reuse one of the APInts storage for this case.


https://reviews.llvm.org/D32946