[PATCH] D32649: [scudo] Add Android support

Aleksey Shlyapnikov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri May 5 14:24:59 PDT 2017


alekseyshl accepted this revision.
alekseyshl added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: lib/scudo/scudo_tls_android.cpp:73
+  // No luck, find the one with the lowest precedence, and slow lock it.
+  u64 LowestPrecedence = UINT64_MAX;
+  for (u32 i = 0; i < NumberOfContexts; i++) {
----------------
I'd call it just 'Precedence', to match ThreadContext. 'LowestPrecedence' usually means 'the last to pick' and here it's the other way.


https://reviews.llvm.org/D32649





More information about the llvm-commits mailing list