[PATCH] D32920: Don't add DBG_VALUE instructions for static allocas in dbg.declare

Reid Kleckner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri May 5 12:57:04 PDT 2017


rnk created this revision.

An llvm.dbg.declare of a static alloca is always added to the
MachineFunction dbg variable map, so these values are entirely
redundant. They survive all the way through codegen to be ignored by
DWARF emission.

Effectively revert r113967

Two bugpoint-reduced test cases from 2012 broke as a result of this
change. Despite my best efforts, I haven't been able to rewrite the test
case using dbg.value. I'm not too concerned about the lost coverage
because these were reduced from the test-suite, which we still run.


https://reviews.llvm.org/D32920

Files:
  llvm/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp
  llvm/test/CodeGen/X86/2012-11-30-misched-dbg.ll
  llvm/test/CodeGen/X86/2012-11-30-regpres-dbg.ll
  llvm/test/DebugInfo/COFF/local-variables.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D32920.98004.patch
Type: text/x-patch
Size: 11905 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170505/934b426c/attachment.bin>


More information about the llvm-commits mailing list