[PATCH] D32890: Split up lld Parallel.h a bit

Zachary Turner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri May 5 11:00:17 PDT 2017


zturner updated this revision to Diff 97988.
zturner added a comment.

- Updated everything to use LLVM naming conventions.
- Hid the Executor stuff even more.  Previously the abstract base class was in the `Executor.h`, now even that is hidden in an anonymous namespace in a cpp file.  The only thing exposed now is `TaskGroup`.

That doesn't mean I'm giving up on trying to get this to parity with the C++ Parallel TS, but I'd like to get this ready for LLVM sooner rather than later, and this seems like the method with the least friction.

I plan to go check the Parallel TS as a follow up and see if there's anything else I can do to get more parity on the interfaces, but at least this way `Executor` is out of the picture for now.


https://reviews.llvm.org/D32890

Files:
  lld/include/lld/Core/Parallel.h
  lld/include/lld/Core/TaskGroup.h
  lld/lib/Core/CMakeLists.txt
  lld/lib/Core/TaskGroup.cpp
  lld/unittests/CoreTests/CMakeLists.txt

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D32890.97988.patch
Type: text/x-patch
Size: 17200 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170505/0dc8f1b7/attachment.bin>


More information about the llvm-commits mailing list