[PATCH] D32762: [Atomics] Let emitTrailingFence take the loaded value. NFC.

[Tim Shen via Phabricator via llvm-commits]

timshen marked an inline comment as done.
timshen added inline comments.


================
Comment at: llvm/lib/CodeGen/AtomicExpandPass.cpp:1098
   if (ShouldInsertFencesForAtomic)
-    TLI->emitTrailingFence(Builder, SuccessOrder, /*IsStore=*/true,
+    TLI->emitTrailingFence(Builder, CI, SuccessOrder, /*IsStore=*/true,
                            /*IsLoad=*/true);
----------------
jyknight wrote:
> It feels a bit strange to pass the two-valued CI result struct here.
I'm not sure what is the "two-valued CL result", but I removed the propagation of IsLoad and IsStore, and now the code seems cleaner and more flexible.


https://reviews.llvm.org/D32762