[PATCH] D32563: Add LiveRangeShrink pass to shrink live range within BB.

Dehao Chen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri May 5 10:06:05 PDT 2017


danielcdh added a comment.

In https://reviews.llvm.org/D32563#747164, @andreadb wrote:

> I had a quick look at the code, and I noticed that you never check for the presence of DBG_VALUE instructions in a basic block.
>  I think that your pass would not work as expected with debug info.
>
> More in general:
>
> - When you check the number of uses of a register, you should skip debug values.
> - When you move an instruction, you should also move its associated debug values.
>
>   A lot of tests have changed as a result of this patch. However, I think there is a value in adding your original test cases involving function calls. Could you please add a new MIR test with code from (at least one of) your original small test cases?


Done


https://reviews.llvm.org/D32563





More information about the llvm-commits mailing list