[PATCH] D32821: Add DWARF verifiers to verify address ranges are correct and scoped correctly.
David Blaikie via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri May 5 09:33:06 PDT 2017
dblaikie added a comment.
In https://reviews.llvm.org/D32821#747269, @aprantl wrote:
> David, are all your concerns addressed?
Nah - I'll go over it on Monday.
> Otherwise from my end this change LGTM (with all outstanding issues addressed).
================
Comment at: lib/DebugInfo/DWARF/DWARFVerifier.cpp:104-105
+ return Die.getOffset() < RHS.Die.getOffset();
+ else
+ return true;
+ }
----------------
Else after return
https://reviews.llvm.org/D32821
More information about the llvm-commits
mailing list