[PATCH] D32833: [Triple] Add method for triple canonicalization
Renato Golin via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri May 5 07:29:32 PDT 2017
rengolin added inline comments.
================
Comment at: lib/Support/Triple.cpp:916
+ Triple += getOSTypeName(OS);
+ if (Environment != Triple::UnknownEnvironment) {
+ Triple += "-";
----------------
A canonical representation should not have optional features.
Also, it should actually have 5 fields, including the object format, which is needed by FreeBSD.
Repository:
rL LLVM
https://reviews.llvm.org/D32833
More information about the llvm-commits
mailing list