[PATCH] D32762: [Atomics] Let emitTrailingFence take the loaded value. NFC.

Tim Northover via llvm-commits llvm-commits at lists.llvm.org
Fri May 5 07:07:59 PDT 2017


On 4 May 2017 at 19:43, Kit Barton via Phabricator via llvm-commits
<llvm-commits at lists.llvm.org> wrote:
> https://reviews.llvm.org/D32763 only handles the trailing fences. Is there going to be another patch that deals with the leading fences as well?

It's unlikely to be appropriate for leading fences. They generally do
very different things semantically, even if they both end up as a
barrier hammer if all the arch has is a barrier.

This change in particular strongly relies on having a value to
construct a dependency from, which you obviously don't have until
you've done the operation.

Not that I'm an expert on PPC but this implementation looked
reasonable to me, and in accordance with what I could find on
implementing C++11 there.

Cheers.

Tim.


More information about the llvm-commits mailing list