[PATCH] D32893: Fix handling of signWrappedSets in access relations

[Tobias Grosser via Phabricator via llvm-commits]

grosser added a comment.

Hi Matthias,

this patch looks very good. I had three minor remarks (see below). As they were very minor, I addressed them directly and immediately committed your patch. These changes are available from r302231.



================
Comment at: test/ScopInfo/sign_wrapped_set.ll:7
+; CHECK-NEXT:    Schedule :=
+; CHECK-NEXT:    [srcHeight] -> { Stmt_for_cond6_preheader_us[i0] -> [i0] };
+target datalayout = "e-m:e-i8:8:32-i16:16:32-i64:64-i128:128-n32:64-S128"
----------------
I would also check the memory access functions here.


================
Comment at: test/ScopInfo/sign_wrapped_set.ll:20
+  %srcPtr.075.us = getelementptr inbounds i8, i8* %srcPtr.075.us.pn, i64 %extended
+  
+  %0 = load i8, i8* %srcPtr.075.us, align 1, !tbaa !0
----------------
Trailing whitespaces.


================
Comment at: test/ScopInfo/sign_wrapped_set.ll:24
+  store i8 %1, i8* %srcPtr.075.us, align 1, !tbaa !0
+  
+  %inc37.us = add nuw i32 %y.072.us, 1
----------------
Trailing whitespaces.


Repository:
  rL LLVM

https://reviews.llvm.org/D32893