[PATCH] D32783: [PartialInlining] Add frequency based cost analysis

[David Li via Phabricator via llvm-commits]

davidxl marked 5 inline comments as done.
davidxl added inline comments.


================
Comment at: lib/Transforms/Utils/CodeExtractor.cpp:23
 #include "llvm/Analysis/BranchProbabilityInfo.h"
+#include "llvm/Analysis/InlineCost.h"
 #include "llvm/Analysis/LoopInfo.h"
----------------
eraman wrote:
> Why do you need this?
for getCallsiteCost and getInlineCost interface.


================
Comment at: lib/Transforms/Utils/CodeExtractor.cpp:754
                                                 header);
+  if (codeReplacerP)
+    *codeReplacerP = codeReplacer;
----------------
eraman wrote:
> Why not grab the (only)user  to this function in unswitchFunction and get the basic block from there. It adds some overhead, but IMO is cleaner than this.
can you clarify on this?


https://reviews.llvm.org/D32783