[PATCH] D32773: Update VP prof metadata during inlining.

[Easwaran Raman via Phabricator via llvm-commits]

eraman added a comment.

LGTM after hoisting the APInt outside the loop (see inlined comment).



================
Comment at: lib/IR/Instruction.cpp:643
+                    .getZExtValue());
+      Val *= APInt(128, S);
+      Vals.push_back(MDB.createConstant(
----------------
Creating APInt objects > 64 bits in length requires heap allocation. So the loop invariant APInt objects (S and T) should be hoisted out. I know this is pre-existing, but it is better to fix this since similar code exists for VP (and where the loop likely executes more iterations).


https://reviews.llvm.org/D32773