[PATCH] D32826: Move Parallel.h from LLD to LLVM
Zachary Turner via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu May 4 12:38:24 PDT 2017
zturner added a comment.
One idea might be to put this in early as a straight move, then in a follow-up patch split it up so that:
1. All of the `LLVM_ENABLE_THREADS=0` stuff is remains in the `.h` file.
2. All of the Windows / ConcRT codepath is in `Windows/Parallel.inc`
3. All of the custom implementations are in `Posix/Parallel.inc`.
This sort of address the concern Chandler had of splitting it up so it's more incremental, but it does so after the fact. I'm a little hesitant to make functional changes at the same time as a code move, since it loses history, so it would be nice if this could be a straight move.
https://reviews.llvm.org/D32826
More information about the llvm-commits
mailing list