[PATCH] D32816: [CMake] Support multi-target runtimes build

[Petr Hosek via Phabricator via llvm-commits]

phosek added inline comments.


================
Comment at: cmake/modules/LLVMExternalProjectUtils.cmake:185
   if(NOT ARG_NO_INSTALL)
-    install(CODE "execute_process\(COMMAND \${CMAKE_COMMAND} -DCMAKE_INSTALL_PREFIX=\${CMAKE_INSTALL_PREFIX} -P ${BINARY_DIR}/cmake_install.cmake \)"
+    install(CODE "execute_process\(COMMAND \${CMAKE_COMMAND} -P ${BINARY_DIR}/cmake_install.cmake \)"
       COMPONENT ${name})
----------------
I'm not sure on what's the best way to handle the install prefix. When building runtimes for multiple targets, only one of them can use the "default" install prefix, others have to use a different one otherwise they'll overwrite each other files.


Repository:
  rL LLVM

https://reviews.llvm.org/D32816