[PATCH] D31262: MIParser/MIRPrinter: Compute block successors if not explicitely specified

[Quentin Colombet via Phabricator via llvm-commits]

qcolombet accepted this revision.
qcolombet added a comment.
This revision is now accepted and ready to land.

Thanks Matthias.

LGTM, nitpicks below.



================
Comment at: include/llvm/CodeGen/MIRPrinter.h:42
+                     SmallVectorImpl<MachineBasicBlock*> &Successors,
+                     bool &IsFallthrough);
+
----------------
Although I understand why this is here, this illustrates my point that this should be a parser thing.


================
Comment at: test/CodeGen/MIR/X86/auto-successor.mir:1
+# RUN: llc -o - %s -run-pass=none -verify-machineinstrs -simplify-mir | FileCheck %s
+---
----------------
Could we have a positive test as well? (I.e., where successors are printed.)


================
Comment at: test/CodeGen/MIR/X86/branch-probabilities.mir:6
+# CHECK: bb.0:
+# CHECK-NEXT: successors: %bb.1(0x66666666), %bb.2(0x1999999a)
+name: test
----------------
This does not seem related to this patch.


Repository:
  rL LLVM

https://reviews.llvm.org/D31262