[PATCH] D32846: [XRay][compiler-rt] Add function id utilities for XRay

[David Blaikie via Phabricator via llvm-commits]

dblaikie accepted this revision.
dblaikie added a comment.
This revision is now accepted and ready to land.

Slightly curious to me that function IDs are > 0, but use a signed type - but no big deal, I guess there's probably a reason.



================
Comment at: test/xray/TestCases/Linux/func-id-utils.cc:26-28
+  // CHECK-LABEL: addresses:
+  // CHECK: #[[MAX]] -> @[[ADDR:.*]]
+  // CHECK-NOT: #0 -> @{{.*}}
----------------
What does this test?

Should the test case print the &foo and &bar, or assert(xray_function_address(1) == &foo), etc?


https://reviews.llvm.org/D32846