[PATCH] D32773: Update VP prof metadata during inlining.

Teresa Johnson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed May 3 17:49:39 PDT 2017


tejohnson added a comment.

I found that not all calls with VP metadata were being scaled after this patch. Specifically, this was VP metadata on a memcpy intrinsic (so profiling the memcpy size values not an indirect call), but it still makes sense to scale them the same way. I confirmed that the call was not in the value map iterated in the caller of this function (updateCallProfile), which is what is iterated to update the inlined instructions in the caller. Are we guaranteed that every inlined instruction would be in there?


https://reviews.llvm.org/D32773





More information about the llvm-commits mailing list