[PATCH] D32721: Accept archive files with no symbol table instad of warning on them.

Mehdi AMINI via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed May 3 16:23:53 PDT 2017


mehdi_amini added a comment.

I personally  think *not* warn is a terrible thing to do when there is a configuration issue. Erroring is annoying, but warning should be intended in such cases!

> True, but on the other hand, it's pretty much the exact same work that the archiver would need to do,

The archiver do it once for potentially a lot of linker invocations.

> and asking the user to change their archiver and rebuild would probably consume even more time.

This is a one time thing, and the user can live with the warning (or pass a flag to disable the warning maybe) if they choose to.


Repository:
  rL LLVM

https://reviews.llvm.org/D32721





More information about the llvm-commits mailing list