[PATCH] D32826: Move Parallel.h from LLD to LLVM
Zachary Turner via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed May 3 14:14:22 PDT 2017
zturner added a comment.
In https://reviews.llvm.org/D32826#745297, @ruiu wrote:
> We have llvm/include/llvm/Support/ThreadPool.h and llvm/include/llvm/Support/thread.h. Did you take a look at these files? It seems parallel_for and parallel_for_each can be implemented on top of them.
I might be willing to take a stab at using `llvm/Support/thread.h`, but it should be in a separate patch, because I think this should one not be any functional change. Using `llvm/Support/thread.h` would potentially allow us to get rid of some of the ugly preprocessor defines in `Parallel.h` though, so I think we should do it.
Using `ThreadPool.h` seems a little more risky. It's almost certain there are subtle differences in the semantics between the two things being used, so it would need to be done much more carefully.
https://reviews.llvm.org/D32826
More information about the llvm-commits
mailing list