[PATCH] D32821: Add DWARF verifiers to verify address ranges are correct and scoped correctly.

[David Blaikie via llvm-commits]

On Wed, May 3, 2017 at 1:43 PM Greg Clayton via Phabricator <
reviews at reviews.llvm.org> wrote:

> clayborg added a comment.
>
> One thing to clarify:
>
>   std::vector<RangeInfoType> DieRangeInfos;
>
> is a vector that only gets as deep as the DIE depth. It doesn't get every
> range for every function, block, or inlined function, it just has a stack
> of ranges for the _current_ DIE depth.
>

Which is part of what I'm confused by - I wouldn't expect to see/don't
understand why there's any code that special-cases subprograms here. They
don't seem special to me.

I'd expect an algorithm that starts at the CU DIE and looks for any DIE
that has ranges. It wouldn't need special cases for any tag types.


>
>   std::set<RangeInfoType> AllFunctionRangeInfos;
>
> Contains one entry for each DW_TAG_subprogram.
>
>
> https://reviews.llvm.org/D32821
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170503/d01eff76/attachment.html>