[PATCH] D32768: [PM] Add ProfileSummaryAnalysis as a required pass in the new pipeline.

Easwaran Raman via llvm-commits llvm-commits at lists.llvm.org
Wed May 3 11:57:25 PDT 2017


-fexperimental-pass-manager + PGO should trigger this. In my case, I am
working on a patch that uses callsite's BFI (without PGO and which requires
-fexperimental-pass-manager) and found this.

On Wed, May 3, 2017 at 11:53 AM, Davide Italiano <dccitaliano at gmail.com>
wrote:

> Makes sense. Is there a way to exercise this behaviour?
>
> Thanks,
>
> --
> Davide
>
> On Wed, May 3, 2017 at 11:52 AM, Easwaran Raman <eraman at google.com> wrote:
> > Without this, the call to MAM.getCachedResult<ProfileSummaryAnalysis>(M)
> in
> > the run method will return nullptr. The inliner doesn't fail because of
> > this, but it effectively becomes a non-PGO inliner.
> >
> > On Wed, May 3, 2017 at 11:49 AM, Davide Italiano via Phabricator
> > <reviews at reviews.llvm.org> wrote:
> >>
> >> davide added a comment.
> >>
> >> This is reasonable. Did you get failures because the profile info
> weren't
> >> available in the inliner?
> >>
> >>
> >> https://reviews.llvm.org/D32768
> >>
> >>
> >>
> >
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170503/b8d92be5/attachment.html>


More information about the llvm-commits mailing list