[PATCH] D32688: [Coverage] Comdat section name should be same as the variable name in COFF format

David Li via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed May 3 09:25:46 PDT 2017


davidxl added inline comments.


================
Comment at: lib/Transforms/Instrumentation/InstrProfiling.cpp:373
   // a section is associated to must precede the associating section. For this
   // reason, we must choose the counter var's name as the name of the comdat.
+  if (Triple(M.getTargetTriple()).isOSBinFormatCOFF())
----------------
Please also fix the stale comment.


https://reviews.llvm.org/D32688





More information about the llvm-commits mailing list