[PATCH] D32324: CodeGen: BlockPlacement: Increase tail duplication size for O3.

[David Li via Phabricator via llvm-commits]

davidxl added inline comments.


================
Comment at: lib/CodeGen/MachineBlockPlacement.cpp:2662
+  // conservative.
+  if (PassConfig->getOptLevel() >= CodeGenOpt::Aggressive) {
+    // At O3 we should be more willing to copy blocks for tail duplication. This
----------------
I think when the aggressive threshold is also explicitly specified, then it should take precedence even at O2. Basically this is the order:

Explicit Aggressive Threshold
Explicit regular Threshold

Implicit Aggressive at O3 and implicit regular at O2.


https://reviews.llvm.org/D32324