[PATCH] D32706: [AArch64] Consider widening instructions in cast cost calculation

[Matthew Simpson via Phabricator via llvm-commits]

mssimpso added a comment.

In https://reviews.llvm.org/D32706#744317, @kristof.beyls wrote:

> Thanks Matt.
>  I'm not familiar enough with this code to feel comfortable approving, so I think someone else should do that.
>  Other than that, I only have one more remark, now that I've looked at the patch again: maybe there should also be a "negative" test, i.e. verifying that a non-zero cost is computed when a widening instruction cannot be generated, e.g. when the type operated on cannot map to a native instruction?


Thanks Kristof! I'll add some negative tests and wait for more reviews.


https://reviews.llvm.org/D32706