[PATCH] D32769: [X86][LWP] Add llvm support for LWP instructions.

[Simon Pilgrim via Phabricator via llvm-commits]

RKSimon added a comment.

In https://reviews.llvm.org/D32769#744477, @andreadb wrote:

> I noticed that according to X86GenInstrInfo.inc, the new LWPINS instructions don't have "UnmodeledSideEffects".
>  However, all the other LWP instructions have flag `UnmodeledSideEffects` set.
>  My understanding is that this is because LWPVAL/LLWPCB/SLWPCB are directly matched from x86 intrinsics with side effects, while LWPINS* are firstly lowered to X86ISD::LWPINS nodes.
>
> Shouldn't we set `hasSideEffects = 1` for the LWPINS variants too? After all, those instructions modify memory by pushing new events in the ring buffer. So, those can both read and write.


I think I just need to add SDNPSideEffect to X86lwpins.


Repository:
  rL LLVM

https://reviews.llvm.org/D32769