[PATCH] D32354: [ELF] - Set DF_STATIC_TLS flag for i386 target.

[George Rimar via Phabricator via llvm-commits]

grimar added inline comments.


================
Comment at: ELF/Relocations.cpp:842
 static void scanRelocs(InputSectionBase &Sec, ArrayRef<RelTy> Rels) {
-  OffsetGetter GetOffset(Sec);
+  scanTlsModel<ELFT>(Sec, Rels);
 
----------------
ruiu wrote:
> This is not beautiful. Since setting DF_STATIC_TLS is not actually that important, I don't want to mess the code up for that feature. What if you add it to `getRelExpr`? That is also ugly, but it might be acceptable.
Placing in getRelExpr probably looks better and does not conflict with D32758. Done.


https://reviews.llvm.org/D32354