[PATCH] D32289: [ELF] - Linkerscript: support combination of linkerscript and --compress-debug-sections.

[George Rimar via Phabricator via llvm-commits]

grimar added inline comments.


================
Comment at: test/ELF/linkerscript/compress-debug-sections.s:17
+# RUN: ld.lld -O0 %t1.o %t2.o %t2.script -o %t2 --compress-debug-sections=zlib
+# RUN: llvm-dwarfdump %t2 | FileCheck %s
+
----------------
ruiu wrote:
> I don't think you are actually testing the new code. Please use llvm-objdump or llvm-readelf to verify that debug sections don't SHT_COMPRESSED if linker scripts are in use. You don't need to use llvm-dwarfdump as the contents doesn't matter.
> Please use llvm-objdump or llvm-readelf to verify that debug sections don't SHT_COMPRESSED if linker scripts are in use.

I think I got what you want to say. Both your comments saying these sections don't compressed. But them are ! We do not support custom layout for them, but compression itself is supported by this patch. That is why I am doing that checks because content matters, as I check that them can be compressed and then decompressed and the content remains the same.


https://reviews.llvm.org/D32289