[PATCH] D32776: Enable branch coalescing on PowerPC

[Nemanja Ivanovic via Phabricator via llvm-commits]

nemanjai added inline comments.


================
Comment at: include/llvm/Target/TargetFrameLowering.h:149
 
+  /// Returns true if the target will correctly handle branch coalescing
+  virtual bool enableBranchCoalescing(const MachineFunction &MF) const {
----------------
I find this an unusual place for this check. What is the relationship between this pass and frame lowering?


================
Comment at: test/CodeGen/PowerPC/select-i1-vs-i1.ll:1029
 
-; FIXME: Because of the way that the late SELECT_* pseudo-instruction expansion
-; works, we end up with two blocks with the same predicate. These could be
-; combined.
+; The default branchCoalescing optimization merged the two identical predicate blocks 
+; that were expanded by the late SELECT_* pseudo-instruction expansion.
----------------
I don't think this comment is necessary here. It should suffice to just remove the FIXME comment. The reason I say that is that the user will not know that we once had this duplicate block issue.


https://reviews.llvm.org/D32776