[PATCH] D32781: [PowerPC] Implement vec_xxsldi and vec_xxpermdi builtins - llvm portion.

[Nemanja Ivanovic via Phabricator via llvm-commits]

nemanjai added a comment.

Minor nit, the description doesn't need to have the signatures for the builtins (since this patch does not add any such builtins). Also, `ATTRS_o_ai` is an implementation detail and not part of the signatures required - on an unrelated note, it will probably not even be used in the final implementation.



================
Comment at: lib/Target/PowerPC/PPCInstrVSX.td:2283
             (v2i64 (COPY_TO_REGCLASS (XXEXTRACTUW $A, imm:$IMM), VSRC))>;
+
+  // Extra patterns expanding to vector Permute Doubleword Immediate
----------------
These don't need to be here. The instructions are not P9 specific. All targets with VSX have them.


================
Comment at: test/CodeGen/PowerPC/p9-xxpermdi.ll:1
+; RUN: llc -mcpu=pwr9 -mtriple=powerpc64le-unknown-linux-gnu \
+; RUN:   -verify-machineinstrs < %s | FileCheck %s
----------------
No need to restrict this to P9.


https://reviews.llvm.org/D32781