[PATCH] D32772: Update llvm-readobj to re-use parsing code

[Zachary Turner via Phabricator via llvm-commits]

zturner created this revision.

llvm-readobj has a lot of hand rolled CodeView parsing code.  Recently I introduced `codeview::StringTableRef` and `codeview::StringTable` which can read and write codeview stringtables from and to its serialized format.  This patch updates `llvm-readobj` to use `StringTableRef` for parsing the string table, and since I'm in the code anyway, updates the file checksum parsing code to use `VarStreamArray<FileChecksumEntry>` which simplifies some error handling and parsing code.


https://reviews.llvm.org/D32772

Files:
  llvm/include/llvm/DebugInfo/CodeView/StringTable.h
  llvm/include/llvm/DebugInfo/CodeView/SymbolVisitorDelegate.h
  llvm/include/llvm/DebugInfo/PDB/Native/PDBStringTable.h
  llvm/include/llvm/Support/BinaryStreamArray.h
  llvm/include/llvm/Support/BinaryStreamRef.h
  llvm/lib/DebugInfo/CodeView/StringTable.cpp
  llvm/lib/DebugInfo/CodeView/SymbolDumper.cpp
  llvm/lib/DebugInfo/PDB/Native/PDBStringTable.cpp
  llvm/tools/llvm-pdbdump/Diff.cpp
  llvm/tools/llvm-pdbdump/LLVMOutputStyle.cpp
  llvm/tools/llvm-pdbdump/YAMLOutputStyle.cpp
  llvm/tools/llvm-readobj/COFFDumper.cpp
  llvm/tools/llvm-readobj/llvm-readobj.h
  llvm/unittests/DebugInfo/PDB/ErrorChecking.h
  llvm/unittests/DebugInfo/PDB/StringTableBuilderTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D32772.97522.patch
Type: text/x-patch
Size: 20913 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170502/8952f338/attachment-0001.bin>