[PATCH] D32754: Add line table verification to lldb-dwarfdump --verify.

[Greg Clayton via Phabricator via llvm-commits]

clayborg added a comment.

In https://reviews.llvm.org/D32754#743899, @probinson wrote:

> Can you verify that each CU (that has DW_AT_stmt_list) points to a different place in .debug_line?


That is a good idea. Maybe we emit a warning? I say that because it seems like a good way to save space for type unique style DWARF to share line tables since they only use the line tables for DW_AT_decl_file and DW_AT_call_file. Is it against the DWARF spec to share a line table? Let me know if you think this should be a warning or error.



================
Comment at: lib/DebugInfo/DWARF/DWARFContext.cpp:404
+      auto StmtFormValue = CU->getUnitDIE().find(DW_AT_stmt_list);
+      if (!StmtFormValue) {
+        // No line table for this compile unit.
----------------
No assertion. It will be handled by the .debug_info and reported there. We just want to get around it here.


https://reviews.llvm.org/D32754