[PATCH] D32713: [DWARFv5] Parse new line-table header format.
Paul Robinson via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue May 2 14:52:22 PDT 2017
probinson marked an inline comment as done.
probinson added inline comments.
================
Comment at: lib/DebugInfo/DWARF/DWARFDebugLine.cpp:143
+ // Get the directory entry description.
+ SmallVector<ContentDescriptor, 4> DirDescriptors =
+ parseV5EntryFormat(DebugLineData, OffsetPtr, EndPrologueOffset);
----------------
dblaikie wrote:
> Use the ContentDescriptors typedef here? (I'd probably skip the typedef/not use it at all - but if you're going to use it, probably makes sense to use it here?)
Doh! Meant to use it here, and also for FileDescriptors. With the type being used in 4 places it seemed like a typedef would be reasonable.
https://reviews.llvm.org/D32713
More information about the llvm-commits
mailing list